Repository navigation
Rename ProcessFactory to Sandbox, create() returns a SandboxExecution - #337
Merged
Merged
Conversation
A Run is the main process plus before/after steps, so the Docker sandbox can later create, copy files in and remove containers around it. No steps are used yet, so there is no behaviour change. Part of #336.
How many commands a run takes is a detail of each sandbox, so HostSandbox and DockerSandbox return their own HostExecution and DockerExecution.
AydinHassan
changed the title
DockerSandbox passes none yet, so there is no behaviour change. Copying files in will add create/cp before and rm after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First task of #336: API change only, no behaviour change.
ProcessFactory→Sandbox,DockerSandbox,HostSandbox.PROCESS_FACTORYenv var is nowSANDBOX(workshops need updating).create()returns aSandboxExecution:HostExecutionorDockerExecution. How many commands a run takes is up to each sandbox.phpschool.io follows in php-school/phpschool.io#363.